Browse Source

improve startup tcl scripts

Fix a couple of layering violations missed in the last round.
Add missing comment headers.
tags/v0.4.0-rc1
Zachary T Welch 14 years ago
parent
commit
47cb10217a
4 changed files with 20 additions and 19 deletions
  1. +0
    -4
      src/helper/startup.tcl
  2. +15
    -0
      src/jtag/startup.tcl
  3. +2
    -0
      src/server/startup.tcl
  4. +3
    -15
      src/target/startup.tcl

+ 0
- 4
src/helper/startup.tcl View File

@@ -61,10 +61,6 @@ proc unknown {args} {
return -code error "Unknown command: $args"
}

proc new_target_name { } {
return [target number [expr [target count] - 1 ]]
}

# Try flipping / and \ to find file if the filename does not
# match the precise spelling
proc find {filename} {


+ 15
- 0
src/jtag/startup.tcl View File

@@ -9,6 +9,21 @@ proc jtag_init {} {
}
}

# This reset logic may be overridden by board/target/... scripts as needed
# to provide a reset that, if possible, is close to a power-up reset.
#
# Exit requirements include: (a) JTAG must be working, (b) the scan
# chain was validated with "jtag arp_init" (or equivalent), (c) nothing
# stays in reset. No TAP-specific scans were performed. It's OK if
# some targets haven't been reset yet; they may need TAP-specific scans.
#
# The "mode" values include: halt, init, run (from "reset" command);
# startup (at OpenOCD server startup, when JTAG may not yet work); and
# potentially more (for reset types like cold, warm, etc)
proc init_reset { mode } {
jtag arp_init-reset
}

#########

# TODO: power_restore and power_dropout are currently neither


+ 2
- 0
src/server/startup.tcl View File

@@ -1,3 +1,5 @@
# Defines basic Tcl procs for OpenOCD server modules

# Handle GDB 'R' packet. Can be overriden by configuration script,
# but it's not something one would expect target scripts to do
# normally


+ 3
- 15
src/target/startup.tcl View File

@@ -1,21 +1,9 @@
#########
# Defines basic Tcl procs for OpenOCD target module

# This reset logic may be overridden by board/target/... scripts as needed
# to provide a reset that, if possible, is close to a power-up reset.
#
# Exit requirements include: (a) JTAG must be working, (b) the scan
# chain was validated with "jtag arp_init" (or equivalent), (c) nothing
# stays in reset. No TAP-specific scans were performed. It's OK if
# some targets haven't been reset yet; they may need TAP-specific scans.
#
# The "mode" values include: halt, init, run (from "reset" command);
# startup (at OpenOCD server startup, when JTAG may not yet work); and
# potentially more (for reset types like cold, warm, etc)
proc init_reset { mode } {
jtag arp_init-reset
proc new_target_name { } {
return [target number [expr [target count] - 1 ]]
}


global in_process_reset
set in_process_reset 0



Loading…
Cancel
Save