Browse Source

cfi: tighten up type usage a bit

sizeof() is a bit less scary than seing assumption
about size of type, no bug as such.

Use NULL instead of 0 for pointers. More obvious that
it is a pointer from code inspection.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
tags/v0.5.0-rc1
Øyvind Harboe 13 years ago
parent
commit
ef92da3315
1 changed files with 3 additions and 2 deletions
  1. +3
    -2
      src/flash/nor/cfi.c

+ 3
- 2
src/flash/nor/cfi.c View File

@@ -805,7 +805,7 @@ FLASH_BANK_COMMAND_HANDLER(cfi_flash_bank_command)

cfi_info = malloc(sizeof(struct cfi_flash_bank));
cfi_info->probed = 0;
cfi_info->erase_region_info = 0;
cfi_info->erase_region_info = NULL;
cfi_info->pri_ext = NULL;
bank->driver_priv = cfi_info;

@@ -2494,7 +2494,8 @@ static int cfi_probe(struct flash_bank *bank)

if (cfi_info->num_erase_regions)
{
cfi_info->erase_region_info = malloc(4 * cfi_info->num_erase_regions);
cfi_info->erase_region_info = malloc(sizeof(*cfi_info->erase_region_info)
* cfi_info->num_erase_regions);
for (i = 0; i < cfi_info->num_erase_regions; i++)
{
retval = cfi_query_u32(bank, 0, 0x2d + (4 * i), &cfi_info->erase_region_info[i]);


Loading…
Cancel
Save