Browse Source

- fix illegal memory access in unregister_command function

git-svn-id: svn://svn.berlios.de/openocd/trunk@1224 b42882b7-edfa-0310-969c-e2dbd0fdcd60
tags/v0.1.0
ntfreak 15 years ago
parent
commit
00b3eb5fed
1 changed files with 19 additions and 11 deletions
  1. +19
    -11
      src/helper/command.c

+ 19
- 11
src/helper/command.c View File

@@ -289,8 +289,10 @@ int unregister_command(command_context_t *context, char *name)
return ERROR_INVALID_ARGUMENTS;

/* find command */
for (c = context->commands; c; c = c->next)
{
c = context->commands;
while(NULL != c)
{
if (strcmp(name, c->name) == 0)
{
/* unlink command */
@@ -300,26 +302,32 @@ int unregister_command(command_context_t *context, char *name)
}
else
{
/* first element in command list */
context->commands = c->next;
}
/* unregister children */
if (c->children)
while(NULL != c->children)
{
for (c2 = c->children; c2; c2 = c2->next)
{
free(c2->name);
free(c2);
}
c2 = c->children;
c->children = c->children->next;
free(c2->name);
c2->name = NULL;
free(c2);
c2 = NULL;
}
/* delete command */
free(c->name);
c->name = NULL;
free(c);
c = NULL;
return ERROR_OK;
}

/* remember the last command for unlinking */
p = c;
c = c->next;
}

return ERROR_OK;


Loading…
Cancel
Save