Browse Source

added comments w.r.t. potential performance problems

git-svn-id: svn://svn.berlios.de/openocd/trunk@1663 b42882b7-edfa-0310-969c-e2dbd0fdcd60
tags/v0.2.0
oharboe 15 years ago
parent
commit
75f98d1649
2 changed files with 13 additions and 0 deletions
  1. +7
    -0
      src/target/arm7tdmi.c
  2. +6
    -0
      src/target/arm_adi_v5.c

+ 7
- 0
src/target/arm7tdmi.c View File

@@ -372,6 +372,13 @@ void arm7tdmi_change_to_arm(target_t *target, u32 *r0, u32 *pc)
*pc -= 0xa;
}


/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
* roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
*
* The solution is to arrange for a large out/in scan in this loop and
* and convert data afterwards.
*/
void arm7tdmi_read_core_regs(target_t *target, u32 mask, u32* core_regs[16])
{
int i;


+ 6
- 0
src/target/arm_adi_v5.c View File

@@ -867,6 +867,12 @@ int mem_ap_read_buf_u16(swjdp_common_t *swjdp, u8 *buffer, int count, u32 addres
return retval;
}

/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
* roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
*
* The solution is to arrange for a large out/in scan in this loop and
* and convert data afterwards.
*/
int mem_ap_read_buf_packed_u8(swjdp_common_t *swjdp, u8 *buffer, int count, u32 address)
{
u32 invalue;


Loading…
Cancel
Save