Fix divide by zero in sinefit

Makefile

@@ -1,14 +1,14 @@
 #URL="http://bucket.mit.edu:8080/nilmdb"
 URL="http://localhost/nilmdb"
 
-all:
+all: test
-ifeq ($(INSIDE_EMACS), t)
-	@make test
-else
-	@echo "Try 'make install'"
-endif
 
-test: test_trainola3
+test:
+ifeq ($(INSIDE_EMACS), t)
+	@make test_sinefit
+else
+	@echo 'No test suite for nilmtools.  Try "make install"'
+endif
 
 test_pipewatch:
 	nilmtools/pipewatch.py -t 3 "seq 10 20" "seq 20 30"
@@ -58,6 +58,14 @@ test_prep: /tmp/raw.dat
 	nilmtools/prep.py -c 2 /test/raw /test/sinefit /test/prep
 	nilmtool extract -s min -e max /test/prep | head -20
 
+test_sinefit:
+	make install >/dev/null 2>&1
+	-nilmtool destroy -R /test/sinefit
+	nilmtool create /test/sinefit float32_3
+	nilmtools/sinefit.py -c 5 -s '2013/03/25 09:11:00' \
+	-e '2013/03/25 10:11:00' /sharon/raw /test/sinefit
+	nilmtool extract -s min -e max /test/sinefit | head -20
+
 test_decimate:
 	-@nilmtool destroy /lees-compressor/no-leak/raw/4 || true
 	-@nilmtool destroy /lees-compressor/no-leak/raw/16 || true

extras/sample-cron-scripts/crontab

@@ -1,5 +1,8 @@
 # Install this by running "crontab crontab" (will replace existing crontab)
 
+SHELL=/bin/bash
+PATH=/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin
+
 # m h dom mon dow cmd
 
 # Run NilmDB processing every 5 minutes
@@ -7,3 +10,6 @@
 
 # Try frequently restarting the capture process in case it died
 */5 * * * * chronic /home/nilm/data/capture.sh
+
+# Run fsck at startup
+@reboot chronic nilmdb-fsck --fix --no-data /home/nilm/data/db/

nilmtools/insert.py

@@ -53,7 +53,7 @@ def parse_args(argv = None):
       is stepped forward to match 'clock'.
 
     - If 'data' is running ahead, there is overlap in the data, and an
-      error is raised.  If '--ignore' is specified, the current file
+      error is raised.  If '--skip' is specified, the current file
       is skipped instead of raising an error.
     """))
     parser.add_argument("-u", "--url", action="store",

nilmtools/math.py

@@ -37,17 +37,21 @@ def sfit4(data, fs):
     i = argmax(F[0:int(N/2)] + F[1:int(N/2+1)])
 
     # Interpolate FFT to get a better result (from Markus [B37])
-    U1 = real(Fc[i])
+    try:
-    U2 = real(Fc[i+1])
+        U1 = real(Fc[i])
-    V1 = imag(Fc[i])
+        U2 = real(Fc[i+1])
-    V2 = imag(Fc[i+1])
+        V1 = imag(Fc[i])
-    n = 2 * pi / N
+        V2 = imag(Fc[i+1])
-    ni1 = n * i
+        n = 2 * pi / N
-    ni2 = n * (i+1)
+        ni1 = n * i
-    K = ((V2-V1)*sin(ni1) + (U2-U1)*cos(ni1)) / (U2-U1)
+        ni2 = n * (i+1)
-    Z1 = V1 * (K - cos(ni1)) / sin(ni1) + U1
+        K = ((V2-V1)*sin(ni1) + (U2-U1)*cos(ni1)) / (U2-U1)
-    Z2 = V2 * (K - cos(ni2)) / sin(ni2) + U2
+        Z1 = V1 * (K - cos(ni1)) / sin(ni1) + U1
-    i = arccos((Z2*cos(ni2) - Z1*cos(ni1)) / (Z2-Z1)) / n
+        Z2 = V2 * (K - cos(ni2)) / sin(ni2) + U2
+        i = arccos((Z2*cos(ni2) - Z1*cos(ni1)) / (Z2-Z1)) / n
+    except Exception:
+        # Just go with the biggest FFT peak
+        i = argmax(F[0:int(N/2)])
 
     # Convert to Hz
     f0 = i * float(fs) / N

nilmtools/prep.py

@@ -81,7 +81,8 @@ def main(argv = None):
     f.check_dest_metadata({ "prep_raw_source": f.src.path,
                             "prep_sinefit_source": sinefit.path,
                             "prep_column": args.column,
-                            "prep_rotation": repr(rotation) })
+                            "prep_rotation": repr(rotation),
+                            "prep_nshift": args.nshift })
 
     # Find the intersection of the usual set of intervals we'd filter,
     # and the intervals actually present in sinefit data.  This is

nilmtools/sinefit.py

@@ -96,8 +96,11 @@ def process(data, interval, args, insert_function, final):
     rows = data.shape[0]
 
     # Estimate sampling frequency from timestamps
-    fs = (rows-1) / (timestamp_to_seconds(data[-1][0]) -
+    ts_min = timestamp_to_seconds(data[0][0])
-                     timestamp_to_seconds(data[0][0]))
+    ts_max = timestamp_to_seconds(data[-1][0])
+    if ts_min >= ts_max:
+        return 0
+    fs = (rows-1) / (ts_max - ts_min)
 
     # Pull out about 3.5 periods of data at once;
     # we'll expect to match 3 zero crossings in each window

nilmtools/trainola.py

@@ -287,8 +287,21 @@ def main(argv = None):
 
     if argv is None:
         argv = sys.argv[1:]
-    if len(argv) != 1:
+    if len(argv) != 1 or argv[0] == '-h' or argv[0] == '--help':
-        raise DataError("need one argument, either a dictionary or JSON string")
+        printf("usage: %s [-h] [-v] <json-config-dictionary>\n\n", sys.argv[0])
+        printf("  Where <json-config-dictionary> is a JSON-encoded " +
+               "dictionary string\n")
+        printf("  with exemplar and stream data.\n\n")
+        printf("  See extras/trainola-test-param*.js in the nilmtools " +
+               "repository\n")
+        printf("  for examples.\n")
+        if len(argv) != 1:
+            raise SystemExit(1)
+        raise SystemExit(0)
+
+    if argv[0] == '-v' or argv[0] == '--version':
+        printf("%s\n", nilmtools.__version__)
+        raise SystemExit(0)
 
     try:
         # Passed in a JSON string (e.g. on the command line)